search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Implement get_import _path #6225

Open Gallaecio opened 3 months ago

Gallaecio commented 3 months ago

I think we should do the following:

Deprecate scrapy.utils.python.get_global_object in favor of a new function named get_import_path, and replace all usages.

Make the argument of get_import_path a positional-only argument, since obj could be a confusing name when passing a class (class instances are not supported).

Find uses of __module__, __name__, and __qualname__, and where appropriate replace them with the new function.

However, we should probably discuss this before someone starts implementing it. Maybe this should be implemented elsewhere, or we should choose a different naming or implementation.

Noman654 commented 3 weeks ago

Hi @Gallaecio, I want to contribute to Scrapy and This is my First Contribution So could you help me to start with this issue

Gallaecio commented 3 weeks ago

Issues tagged with discuss are not a good choice, as it is not yet clear how or if they should be addressed. Maybe some other ticket?

Noman654 commented 3 weeks ago

@Gallaecio got it. Thanks