search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Refactor _get_inputs to reduce complexity #6237

Closed noon-io closed 1 month ago

noon-io commented 2 months ago

As part of a school assignment, the CCN of _get_inputs has been lowered from 16 to 7 by splitting up two blocks into sub-functions.

codecov[bot] commented 2 months ago

Codecov Report

Merging #6237 (a7e110a) into master (ba8993e) will increase coverage by 0.00%. Report is 2 commits behind head on master. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6237 +/- ## ======================================= Coverage 88.61% 88.61% ======================================= Files 161 161 Lines 11775 11779 +4 Branches 1908 1908 ======================================= + Hits 10434 10438 +4 Misses 1011 1011 Partials 330 330 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/http/request/form.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2h0dHAvcmVxdWVzdC9mb3JtLnB5) | `94.85% <100.00%> (+0.15%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6237/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)