scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Fix and re-enable `unnecessary-comprehension` and `use-dict-literal` pylint tags #6257

Closed Laerte closed 2 months ago

Laerte commented 2 months ago

Fixes #6254

codecov[bot] commented 2 months ago

Codecov Report

Merging #6257 (26a16f2) into master (532cc8a) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6257 +/- ## ======================================= Coverage 88.89% 88.89% ======================================= Files 161 161 Lines 11776 11776 Branches 1914 1913 -1 ======================================= Hits 10468 10468 Misses 964 964 Partials 344 344 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/downloadermiddlewares/httpcompression.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2Rvd25sb2FkZXJtaWRkbGV3YXJlcy9odHRwY29tcHJlc3Npb24ucHk=) | `91.07% <100.00%> (ø)` | | | [scrapy/spiders/crawl.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NwaWRlcnMvY3Jhd2wucHk=) | `96.55% <ø> (ø)` | | | [scrapy/utils/python.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3V0aWxzL3B5dGhvbi5weQ==) | `88.53% <100.00%> (ø)` | |