scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

bandit: allow-list false positives #6260

Closed Gallaecio closed 2 months ago

Gallaecio commented 2 months ago

Ignore inline (# nosec) some security issues reported by Bandit that are not actual security issues in Scrapy.

codecov[bot] commented 2 months ago

Codecov Report

Merging #6260 (31cbbb5) into master (198f5cf) will not change coverage. The diff coverage is 83.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6260 +/- ## ======================================= Coverage 88.89% 88.89% ======================================= Files 161 161 Lines 11776 11776 Branches 1913 1913 ======================================= Hits 10468 10468 Misses 964 964 Partials 344 344 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/commands/bench.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvbW1hbmRzL2JlbmNoLnB5) | `100.00% <100.00%> (ø)` | | | [scrapy/core/downloader/\_\_init\_\_.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9fX2luaXRfXy5weQ==) | `91.72% <100.00%> (ø)` | | | [scrapy/exporters.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4cG9ydGVycy5weQ==) | `100.00% <100.00%> (ø)` | | | [scrapy/extensions/httpcache.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4dGVuc2lvbnMvaHR0cGNhY2hlLnB5) | `95.47% <100.00%> (ø)` | | | [scrapy/extensions/spiderstate.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4dGVuc2lvbnMvc3BpZGVyc3RhdGUucHk=) | `100.00% <100.00%> (ø)` | | | [scrapy/pqueues.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3BxdWV1ZXMucHk=) | `99.17% <100.00%> (ø)` | | | [scrapy/settings/default\_settings.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NldHRpbmdzL2RlZmF1bHRfc2V0dGluZ3MucHk=) | `98.80% <100.00%> (ø)` | | | [scrapy/shell.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NoZWxsLnB5) | `68.65% <100.00%> (ø)` | | | [scrapy/squeues.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NxdWV1ZXMucHk=) | `100.00% <100.00%> (ø)` | | | [scrapy/utils/engine.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3V0aWxzL2VuZ2luZS5weQ==) | `77.27% <100.00%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/scrapy/scrapy/pull/6260?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | |