search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Do not use incompatible brotlipy if installed #6262

Closed Gallaecio closed 2 months ago

Gallaecio commented 2 months ago

Resolves #6261.

codecov[bot] commented 2 months ago

Codecov Report

Merging #6262 (3cbdad9) into 2.11 (1932722) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.11 #6262 +/- ## ========================================== + Coverage 88.93% 88.95% +0.01% ========================================== Files 163 163 Lines 11661 11662 +1 Branches 1897 1897 ========================================== + Hits 10371 10374 +3 + Misses 976 974 -2 Partials 314 314 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/downloadermiddlewares/httpcompression.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2Rvd25sb2FkZXJtaWRkbGV3YXJlcy9odHRwY29tcHJlc3Npb24ucHk=) | `95.55% <100.00%> (+2.29%)` | :arrow_up: |
Gallaecio commented 2 months ago

Let’s go with https://github.com/scrapy/scrapy/pull/6261 ’s approach to allow brotlipy as well (unofficially), but maybe move the method selection to import time.