search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Add brotlicffi support #6269

Closed Laerte closed 2 months ago

Laerte commented 2 months ago

Fix #6263

codecov[bot] commented 2 months ago

Codecov Report

Merging #6269 (99f7165) into master (bf14935) will decrease coverage by 0.03%. Report is 1 commits behind head on master. The diff coverage is 50.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6269 +/- ## ========================================== - Coverage 88.91% 88.88% -0.03% ========================================== Files 161 161 Lines 11796 11802 +6 Branches 1914 1914 ========================================== + Hits 10488 10490 +2 - Misses 964 968 +4 Partials 344 344 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/downloadermiddlewares/httpcompression.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2Rvd25sb2FkZXJtaWRkbGV3YXJlcy9odHRwY29tcHJlc3Npb24ucHk=) | `89.56% <50.00%> (-1.51%)` | :arrow_down: | | [scrapy/utils/\_compression.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3V0aWxzL19jb21wcmVzc2lvbi5weQ==) | `89.61% <50.00%> (-2.29%)` | :arrow_down: |
wRAR commented 2 months ago

I guess we need an extra-deps job for PyPy?

wRAR commented 2 months ago

Or no, we install brotli* for regular tests.

Laerte commented 2 months ago

Or no, we install brotli* for regular tests.

Yeah I replaced the PyPy pinned version for this one, should I create extra-deps?