search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
50.99k stars 10.34k forks source link

Fix WindowsRunSpiderCommandTest skip outside Windows for older Twisted #6290

Closed Gallaecio closed 1 month ago

Gallaecio commented 1 month ago

Fixes https://github.com/scrapy/scrapy/issues/6286

codecov[bot] commented 1 month ago

Codecov Report

Merging #6290 (e72de11) into master (642af40) will increase coverage by 0.10%. Report is 1 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6290 +/- ## ========================================== + Coverage 88.52% 88.62% +0.10% ========================================== Files 161 161 Lines 11969 11969 Branches 1929 1929 ========================================== + Hits 10595 10608 +13 + Misses 1016 1005 -11 + Partials 358 356 -2 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6290/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)
wRAR commented 1 month ago

Test failures are probably caused by a missing super() call?