scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
50.99k stars 10.34k forks source link

fix test expectations #6316

Closed ghost closed 2 weeks ago

ghost commented 2 weeks ago

Fixes #6312

codecov[bot] commented 2 weeks ago

Codecov Report

Merging #6316 (6ea109a) into master (1d11ea3) will decrease coverage by 0.05%. Report is 1 commits behind head on master. The diff coverage is n/a.

:exclamation: Current head 6ea109a differs from pull request most recent head a339df3. Consider uploading reports for the commit a339df3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6316 +/- ## ========================================== - Coverage 83.92% 83.88% -0.05% ========================================== Files 161 161 Lines 11972 11972 Branches 1865 1927 +62 ========================================== - Hits 10048 10043 -5 - Misses 1588 1594 +6 + Partials 336 335 -1 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)
wRAR commented 2 weeks ago

Thanks!

ghost commented 2 weeks ago

Should I make a similar PR for scrapy/itemloaders#76?

Gallaecio commented 2 weeks ago

Should I make a similar PR for scrapy/itemloaders#76?

That would be awesome!