scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Full typing for scrapy/extensions, part 3. #6325

Closed wRAR closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 97.17514% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.87%. Comparing base (1d11ea3) to head (f5b65de). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6325 +/- ## ========================================== + Coverage 83.92% 88.87% +4.94% ========================================== Files 161 161 Lines 11972 12003 +31 Branches 1865 1930 +65 ========================================== + Hits 10048 10668 +620 + Misses 1588 982 -606 - Partials 336 353 +17 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6325?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/extensions/postprocessing.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6325?src=pr&el=tree&filepath=scrapy%2Fextensions%2Fpostprocessing.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4dGVuc2lvbnMvcG9zdHByb2Nlc3NpbmcucHk=) | `98.41% <100.00%> (ø)` | | | [scrapy/utils/iterators.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6325?src=pr&el=tree&filepath=scrapy%2Futils%2Fiterators.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3V0aWxzL2l0ZXJhdG9ycy5weQ==) | `93.33% <ø> (+1.36%)` | :arrow_up: | | [scrapy/extensions/httpcache.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6325?src=pr&el=tree&filepath=scrapy%2Fextensions%2Fhttpcache.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4dGVuc2lvbnMvaHR0cGNhY2hlLnB5) | `94.84% <97.01%> (-0.64%)` | :arrow_down: | | [scrapy/extensions/feedexport.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6325?src=pr&el=tree&filepath=scrapy%2Fextensions%2Ffeedexport.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4dGVuc2lvbnMvZmVlZGV4cG9ydC5weQ==) | `94.53% <97.24%> (+11.20%)` | :arrow_up: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6325/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)