search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Typing for build_from_*. #6326

Closed wRAR closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.81%. Comparing base (57acad3) to head (36064ad).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6326 +/- ## ========================================== + Coverage 86.71% 88.81% +2.10% ========================================== Files 161 161 Lines 11995 12010 +15 Branches 1756 1931 +175 ========================================== + Hits 10401 10667 +266 + Misses 1237 990 -247 + Partials 357 353 -4 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6326?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/core/engine.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6326?src=pr&el=tree&filepath=scrapy%2Fcore%2Fengine.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZW5naW5lLnB5) | `85.71% <100.00%> (+0.05%)` | :arrow_up: | | [scrapy/core/scheduler.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6326?src=pr&el=tree&filepath=scrapy%2Fcore%2Fscheduler.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvc2NoZWR1bGVyLnB5) | `92.08% <100.00%> (+0.11%)` | :arrow_up: | | [scrapy/crawler.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6326?src=pr&el=tree&filepath=scrapy%2Fcrawler.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NyYXdsZXIucHk=) | `89.17% <100.00%> (+0.86%)` | :arrow_up: | | [scrapy/utils/misc.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6326?src=pr&el=tree&filepath=scrapy%2Futils%2Fmisc.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3V0aWxzL21pc2MucHk=) | `97.46% <83.33%> (-1.23%)` | :arrow_down: | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6326/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)
Gallaecio commented 2 weeks ago

Well, typing passed, so did most jobs, so I’m merging despite the Covecov issue.