search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

'json' selector type not documented #6328

Closed mohmad-null closed 1 week ago

mohmad-null commented 2 weeks ago

https://docs.scrapy.org/en/latest/topics/selectors.html

type defines the selector type, it can be "html", "xml" or None (default).

But my tests are now failing because it's returning json type for actual json docs now.

kisharnath commented 2 weeks ago

can I send PR for this?

GeorgeA92 commented 2 weeks ago

@mohmad-null

But my tests are now failing because it's returning json type for actual json docs now.

Can You provide a bit more detailed info about Your tests that failed? Does it look like https://github.com/scrapy/scrapy/issues/5923 or https://github.com/scrapy/parsel/issues/275 ?

mohmad-null commented 2 weeks ago

Can You provide a bit more detailed info about Your tests that failed?

The failing tests were specific to my code. Basically I expected one selector type and now get another one, so the code went down a different channel and I got a different result. Nothing scrapy related there.