scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Full typing for scrapy/*.py #6333

Closed wRAR closed 1 week ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.56604% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 88.36%. Comparing base (d7da298) to head (203fa96). Report is 1 commits behind head on master.

:exclamation: Current head 203fa96 differs from pull request most recent head 2cba789. Consider uploading reports for the commit 2cba789 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6333 +/- ## ========================================== + Coverage 83.88% 88.36% +4.47% ========================================== Files 161 161 Lines 12010 12048 +38 Branches 1929 1875 -54 ========================================== + Hits 10075 10646 +571 + Misses 1598 1038 -560 - Partials 337 364 +27 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/core/downloader/\_\_init\_\_.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9fX2luaXRfXy5weQ==) | `91.83% <100.00%> (ø)` | | | [scrapy/core/scheduler.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fcore%2Fscheduler.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvc2NoZWR1bGVyLnB5) | `92.25% <100.00%> (+0.16%)` | :arrow_up: | | [scrapy/extension.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fextension.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2V4dGVuc2lvbi5weQ==) | `100.00% <100.00%> (ø)` | | | [scrapy/cmdline.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fcmdline.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NtZGxpbmUucHk=) | `67.16% <94.44%> (-0.02%)` | :arrow_down: | | [scrapy/robotstxt.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Frobotstxt.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3JvYm90c3R4dC5weQ==) | `85.55% <96.77%> (+12.52%)` | :arrow_up: | | [scrapy/item.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fitem.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2l0ZW0ucHk=) | `95.23% <89.47%> (-3.13%)` | :arrow_down: | | [scrapy/squeues.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fsqueues.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NxdWV1ZXMucHk=) | `93.18% <92.30%> (-1.88%)` | :arrow_down: | | [scrapy/resolver.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fresolver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3Jlc29sdmVyLnB5) | `89.15% <89.28%> (-3.16%)` | :arrow_down: | | [scrapy/mail.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fmail.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L21haWwucHk=) | `75.51% <80.00%> (-0.54%)` | :arrow_down: | | [scrapy/pqueues.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6333?src=pr&el=tree&filepath=scrapy%2Fpqueues.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3BxdWV1ZXMucHk=) | `94.02% <86.53%> (-5.15%)` | :arrow_down: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6333/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)