search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.16k stars 10.35k forks source link

Use the Self type hint in from_crawler/from_settings. #6335

Closed wRAR closed 1 week ago

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.49%. Comparing base (d7da298) to head (4b47a5d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6335 +/- ## ========================================== + Coverage 83.88% 89.49% +5.60% ========================================== Files 161 161 Lines 12010 11890 -120 Branches 1929 1805 -124 ========================================== + Hits 10075 10641 +566 + Misses 1598 954 -644 + Partials 337 295 -42 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/core/downloader/contextfactory.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2Fcontextfactory.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9jb250ZXh0ZmFjdG9yeS5weQ==) | `88.33% <100.00%> (+12.92%)` | :arrow_up: | | [scrapy/core/downloader/handlers/ftp.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2Fhandlers%2Fftp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9oYW5kbGVycy9mdHAucHk=) | `98.46% <100.00%> (+0.07%)` | :arrow_up: | | [scrapy/core/downloader/handlers/http10.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2Fhandlers%2Fhttp10.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9oYW5kbGVycy9odHRwMTAucHk=) | `100.00% <100.00%> (ø)` | | | [scrapy/core/downloader/handlers/http11.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2Fhandlers%2Fhttp11.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9oYW5kbGVycy9odHRwMTEucHk=) | `94.01% <100.00%> (+0.04%)` | :arrow_up: | | [scrapy/core/downloader/handlers/http2.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2Fhandlers%2Fhttp2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9oYW5kbGVycy9odHRwMi5weQ==) | `100.00% <100.00%> (+54.92%)` | :arrow_up: | | [scrapy/core/downloader/handlers/s3.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fcore%2Fdownloader%2Fhandlers%2Fs3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2NvcmUvZG93bmxvYWRlci9oYW5kbGVycy9zMy5weQ==) | `93.75% <100.00%> (+72.01%)` | :arrow_up: | | [scrapy/http/request/\_\_init\_\_.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fhttp%2Frequest%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L2h0dHAvcmVxdWVzdC9fX2luaXRfXy5weQ==) | `97.80% <100.00%> (ø)` | | | [scrapy/pipelines/files.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fpipelines%2Ffiles.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3BpcGVsaW5lcy9maWxlcy5weQ==) | `79.80% <100.00%> (+7.90%)` | :arrow_up: | | [scrapy/pipelines/images.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fpipelines%2Fimages.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3BpcGVsaW5lcy9pbWFnZXMucHk=) | `94.96% <100.00%> (+67.42%)` | :arrow_up: | | [scrapy/pipelines/media.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree&filepath=scrapy%2Fpipelines%2Fmedia.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3BpcGVsaW5lcy9tZWRpYS5weQ==) | `99.19% <100.00%> (+0.01%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/scrapy/scrapy/pull/6335?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | | ... and [66 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6335/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)