search

scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.29k stars 10.37k forks source link

Full typing for scrapy/spiders. #6356

Closed wRAR closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.69%. Comparing base (180bc9b) to head (e0bec78). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6356 +/- ## ========================================== + Coverage 85.00% 89.69% +4.69% ========================================== Files 161 161 Lines 11962 11974 +12 Branches 1872 1699 -173 ========================================== + Hits 10168 10740 +572 + Misses 1512 927 -585 - Partials 282 307 +25 ``` | [Files](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [scrapy/spiders/\_\_init\_\_.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?src=pr&el=tree&filepath=scrapy%2Fspiders%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NwaWRlcnMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [scrapy/spiders/crawl.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?src=pr&el=tree&filepath=scrapy%2Fspiders%2Fcrawl.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NwaWRlcnMvY3Jhd2wucHk=) | `96.87% <100.00%> (+0.28%)` | :arrow_up: | | [scrapy/spiders/init.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?src=pr&el=tree&filepath=scrapy%2Fspiders%2Finit.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NwaWRlcnMvaW5pdC5weQ==) | `100.00% <100.00%> (ø)` | | | [scrapy/spiders/sitemap.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?src=pr&el=tree&filepath=scrapy%2Fspiders%2Fsitemap.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NwaWRlcnMvc2l0ZW1hcC5weQ==) | `85.36% <100.00%> (+0.18%)` | :arrow_up: | | [scrapy/utils/sitemap.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?src=pr&el=tree&filepath=scrapy%2Futils%2Fsitemap.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3V0aWxzL3NpdGVtYXAucHk=) | `96.15% <100.00%> (ø)` | | | [scrapy/spiders/feed.py](https://app.codecov.io/gh/scrapy/scrapy/pull/6356?src=pr&el=tree&filepath=scrapy%2Fspiders%2Ffeed.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#diff-c2NyYXB5L3NwaWRlcnMvZmVlZC5weQ==) | `69.56% <83.33%> (-3.46%)` | :arrow_down: | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/scrapy/scrapy/pull/6356/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy)