search

scrapy / scrapyd-client

Command line client for Scrapyd server
BSD 3-Clause "New" or "Revised" License
770 stars 146 forks source link

Default to current timestamp egg file name when a dir is passed to --… #52

Closed aleroot closed 3 years ago

aleroot commented 7 years ago

Default the file name of the --build-egg output to the current timestamp in the case just a folder is passed as parameter. In the case the parameter is a file the behaviour remain exactly the same as before.

Example :

scrapyd-deploy --build-egg /home/user/ /home/user/1511341699.egg file generated ...

I've implemented it, since I have a docker image build script that generate the egg and then copy to the docker image all the generated eggs in a given folder...

aleroot commented 6 years ago

Could someone check this pull request and merge please ?

It is a feature I'm using extensively and I would like to have it in the upstream version of scrapy.

Thanks.

jpmckinney commented 3 years ago

Could you not run, for example:

scrapyd-deploy --build-egg /home/user/$(date +"%s").egg

If so, that is preferred, to avoid adding another feature to scrapyd-client.