scrapy / scrapyd-client

Command line client for Scrapyd server

BSD 3-Clause "New" or "Revised" License

770 stars 146 forks source link

Prepare for release #87

Closed jpmckinney closed 3 years ago

jpmckinney commented 3 years ago

closes #84

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ede5f0b). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage          ?   60.60%           
=========================================
  Files             ?        5           
  Lines             ?      363           
  Branches          ?        0           
=========================================
  Hits              ?      220           
  Misses            ?      143           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ede5f0b...cd4b087. Read the comment docs.

jpmckinney commented 3 years ago

Requesting review prior to tagging for release. I removed .bumpversion.cfg because it automatically creates tags, which I find very undesirable as it can accidentally push versions to PyPI. Changing the number in VERSION is easy enough.

jpmckinney commented 3 years ago

Note: Publication to TestPyPI is failing because the TEST_PYPI_TOKEN secret isn't set. In my own projects, I set this organization-wide, so that all packages, on every build, can test publication to PyPI.

The workflow also needs a PYPI_TOKEN secret.

jpmckinney commented 3 years ago

Thanks for the review! The comments have been integrated.

I also added a commit to include the changelog on PyPI, similar in approach to https://github.com/scrapy/parsel/blob/master/setup.py.

Gallaecio commented 3 years ago

TEST_PYPI_TOKEN defined, restarting tests…

Gallaecio commented 3 years ago

@jpmckinney Feel free to merge

jpmckinney commented 3 years ago

1.2.0 is on PyPI 🚀 https://pypi.org/project/scrapyd-client/