search

scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.96k stars 569 forks source link

get_project_list() must only look for directories #338

Closed Digenis closed 5 years ago

Digenis commented 5 years ago

Files in eggs_dir shouldn't be there in the first place but when they are, they shouldn't be understood as projects.

I was going to write a proper fix for #237 with checks for directories in the config but os.path.samefile() got windows support in py3 so I will not bother until 1.4.

A fix for #237 shouldn't resemble this patch at all.

codecov[bot] commented 5 years ago

Codecov Report

Merging #338 into master will increase coverage by 0.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   68.25%   68.48%   +0.23%     
==========================================
  Files          17       17              
  Lines         863      860       -3     
  Branches      103      104       +1     
==========================================
  Hits          589      589              
+ Misses        245      241       -4     
- Partials       29       30       +1
Impacted Files Coverage Δ
scrapyd/utils.py 76.92% <100%> (+0.25%) :arrow_up:
scrapyd/config.py 88.88% <0%> (+3.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4e430f...d4bbb7b. Read the comment docs.