search

scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.96k stars 569 forks source link

log encoding and charset header #342

Closed Digenis closed 2 years ago

Digenis commented 5 years ago

Currently scrapy uses utf-8 in the logs by default. Scrapyd's responses when sending the logs don't set a charset and users are presented with gibberish instead of non-ascii text.

Many decisions in scrapyd are already based on scrapy's default configuration and, anyway, anyone changing the utf-8 default to a different encoding is asking for trouble.

jpmckinney commented 3 years ago

Is the solution to set a charset for the response containing the log file?

Or is this a non-issue? I can read logs that contain UTF-8 characters, whether in the browser or on the command-line, and they are not gibberish.

jpmckinney commented 2 years ago

Closing as cannot reproduce the issue.

Digenis commented 2 years ago

It was the browsers' encoding detection that wasn't favoring utf8 as much as it should. Maybe now it does.