scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.93k stars 571 forks source link

[eggstorage] remove deprecated distutils.LooseVersion #434

Closed pawelmhm closed 1 year ago

pawelmhm commented 2 years ago

fixes #426

codecov[bot] commented 2 years ago

Codecov Report

Merging #434 (07ad720) into master (83aec7a) will increase coverage by 0.09%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   79.67%   79.77%   +0.09%     
==========================================
  Files          23       23              
  Lines        1053     1058       +5     
==========================================
+ Hits          839      844       +5     
  Misses        214      214              
Flag Coverage Δ
unittests 79.77% <76.92%> (+0.09%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scrapyd/scripts/scrapyd_run.py 0.00% <ø> (ø)
setup.py 0.00% <ø> (ø)
scrapyd/utils.py 88.70% <72.72%> (+0.47%) :arrow_up:
scrapyd/eggstorage.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83aec7a...07ad720. Read the comment docs.

pawelmhm commented 2 years ago

fixes #426

jpmckinney commented 1 year ago

Redid commits in #469, as easier than resolving conflicts.