Closed jpmckinney closed 2 years ago
Merging #440 (e87e49e) into master (129a676) will increase coverage by
0.68%
. The diff coverage is0.00%
.:exclamation: Current head e87e49e differs from pull request most recent head 49ecbe0. Consider uploading reports for the commit 49ecbe0 to get more accurate results
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 79.67% 80.36% +0.68%
==========================================
Files 23 23
Lines 1053 1044 -9
==========================================
Hits 839 839
+ Misses 214 205 -9
Flag | Coverage Δ | |
---|---|---|
unittests | 80.36% <0.00%> (+0.68%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
setup.py | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 129a676...49ecbe0. Read the comment docs.
@Gallaecio @pablohoffman Are you able to set the TEST_PYPI_TOKEN
secret on this repository? Same as was done for scrapyd-client: https://github.com/scrapy/scrapyd-client/pull/87#issuecomment-925474485
I'll merge this PR without the TestPyPI integration for now.
Are you able to set the
TEST_PYPI_TOKEN
secret on this repository?
Done!
Thank you! #446
@Gallaecio Hmm, #446 is failing:
HTTPError: 403 Forbidden from https://test.pypi.org/legacy/
The user 'scrapy' isn't allowed to upload to project 'scrapyd'.
Does the user scrapy have an account at test.pypi.org? It's independent from www.pypi.org.
I'm also assuming the secret is indeed named TEST_PYPI_TOKEN
.
Oh, https://test.pypi.org/project/scrapyd/ exists already and does not seem to have scrapy as a maintainer. I did not bother to check, I assumed it would not exist yet. @curita Could you add scrapy
as a co-maintainer to the scrapyd
package on the testing PyPI service?
@Gallaecio done! I added scrapy
as owner of the project.
@jpmckinney I believe the build should work now!
It works! Thank you 🎉
@Gallaecio @curita The workflow is giving the following error, meaning I can't release a new version of Scrapyd. Can you set up 2FA on the scrapy PyPI user? You will need to do this on both test.pypi.org and pypi.org
ERROR HTTPError: 400 Bad Request from https://test.pypi.org/legacy/
User 'scrapy' does not have two-factor authentication enabled. Please
enable two-factor authentication before attempting to upload to PyPI.
See https://test.pypi.org/help/#two-factor-authentication for more
information.
I believe it is already set up in pypi.org, but I’ll try to get it done in test.pypi.org