scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.96k stars 570 forks source link

Remove `six` package dependency #458

Closed Laerte closed 1 year ago

Laerte commented 1 year ago

We don't need the bindings since we support python 3.6+.

@jpmckinney also: Can i open another PR to drop support of python 3.6 aswell?

jpmckinney commented 1 year ago

Yes, can do!

codecov[bot] commented 1 year ago

Codecov Report

Merging #458 (9655005) into master (c9cacd3) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   81.86%   81.87%           
=======================================
  Files          22       22           
  Lines        1009     1004    -5     
=======================================
- Hits          826      822    -4     
+ Misses        183      182    -1     
Flag Coverage Δ
unittests 81.87% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
scrapyd/environ.py 82.22% <100.00%> (ø)
scrapyd/poller.py 96.55% <100.00%> (-0.12%) :arrow_down:
scrapyd/utils.py 88.59% <100.00%> (+0.46%) :arrow_up:
scrapyd/website.py 91.17% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.