scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.92k stars 569 forks source link

Api job url #467

Closed mxdev88 closed 1 year ago

mxdev88 commented 1 year ago

closes #464

codecov[bot] commented 1 year ago

Codecov Report

Merging #467 (c410368) into master (2160e5d) will increase coverage by 0.77%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   86.87%   87.64%   +0.77%     
==========================================
  Files          41       41              
  Lines        1828     1862      +34     
==========================================
+ Hits         1588     1632      +44     
+ Misses        240      230      -10     
Flag Coverage Δ
unittests 87.64% <100.00%> (+0.77%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scrapyd/jobstorage.py 100.00% <100.00%> (ø)
scrapyd/tests/conftest.py 100.00% <100.00%> (ø)
scrapyd/tests/test_webservice.py 100.00% <100.00%> (ø)
scrapyd/tests/test_website.py 100.00% <100.00%> (ø)
scrapyd/webservice.py 76.06% <100.00%> (+7.10%) :arrow_up:
scrapyd/website.py 93.20% <100.00%> (+2.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mxdev88 commented 1 year ago

@jpmckinney unsure about the linting failure. it was passing on the fork. https://github.com/mxdev88/scrapyd/actions/runs/3936454424/jobs/6732997024

jpmckinney commented 1 year ago

Thank you!