scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.92k stars 569 forks source link

Replace distutils.version.LooseVersion with packaging.version Version #469

Closed jpmckinney closed 1 year ago

jpmckinney commented 1 year ago

fixes #426

codecov[bot] commented 1 year ago

Codecov Report

Merging #469 (7ee643f) into master (cb9c7c0) will increase coverage by 0.13%. The diff coverage is 100.00%.

:exclamation: Current head 7ee643f differs from pull request most recent head a4b377d. Consider uploading reports for the commit a4b377d to get more accurate results

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   86.74%   86.87%   +0.13%     
==========================================
  Files          41       41              
  Lines        1810     1828      +18     
==========================================
+ Hits         1570     1588      +18     
  Misses        240      240              
Flag Coverage Δ
unittests 86.87% <100.00%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
scrapyd/eggstorage.py 100.00% <100.00%> (ø)
scrapyd/tests/test_dont_load_settings.py 90.90% <100.00%> (ø)
scrapyd/tests/test_eggstorage.py 94.36% <100.00%> (+0.81%) :arrow_up:
scrapyd/tests/test_sqlite.py 100.00% <100.00%> (ø)
scrapyd/tests/test_utils.py 100.00% <100.00%> (ø)
scrapyd/utils.py 89.16% <100.00%> (+0.57%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.