scrapy / scrapyd

A service daemon to run Scrapy spiders
https://scrapyd.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
2.92k stars 569 forks source link

Add configuration via env vars #499

Closed fkromer closed 2 months ago

fkromer commented 8 months ago

Allows to override scrapyd.conf config values http_port, bind_address, username, password via env vars SCRAPYD_HTTP_PORT, SCRAPYD_BIND_ADDRESS, SCRAPYD_USERNAME, SCRAPYD_PASSWORD.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (00e30f8) 87.20% compared to head (36383ef) 87.00%.

Files Patch % Lines
scrapyd/app.py 55.55% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #499 +/- ## ========================================== - Coverage 87.20% 87.00% -0.20% ========================================== Files 41 41 Lines 1883 1893 +10 ========================================== + Hits 1642 1647 +5 - Misses 241 246 +5 ``` | [Flag](https://app.codecov.io/gh/scrapy/scrapyd/pull/499/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/scrapy/scrapyd/pull/499/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy) | `87.00% <55.55%> (-0.20%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jpmckinney commented 1 month ago

Done in c6fd8834a1c44ccb38aa123e139be5ae56298d5f