search

scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

add w3lib test on scurl #37

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

Add w3lib test into scurl by cloning it :)

codecov[bot] commented 6 years ago

Codecov Report

Merging #37 into master will decrease coverage by 27.7%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #37       +/-   ##
===========================================
- Coverage   90.12%   62.42%   -27.71%     
===========================================
  Files           2        2               
  Lines         314      314               
===========================================
- Hits          283      196       -87     
- Misses         31      118       +87
Impacted Files Coverage Δ
scurl/canonicalize.pyx 21.42% <0%> (-70.41%) :arrow_down:
scurl/cgurl.pyx 81.01% <0%> (-8.34%) :arrow_down:
malloxpb commented 6 years ago

Hey @lopuhin , I think this PR is ready for review 😄

malloxpb commented 6 years ago

Hey @lopuhin , I just removed the canonicalize_url test I copied from w3lib, and I cloned the #scrapy/w3lib#110 branch instead of the master branch for now. We will change this back when it's merged 😄 Let me know what you think :-)