search

scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

Packaging #44

Closed lopuhin closed 6 years ago

lopuhin commented 6 years ago

Hey @nctl144 I checked packaging by running python setup.py sdist and then installing dist/scurl-0.1.0.tar.gz in a fresh virtual environment (python3.6 on OS X), and everything worked well besides one issue: six is needed for scurl to work, but it's not listed in scurl requirements (https://packaging.python.org/discussions/install-requires-vs-requirements/#install-requires).

malloxpb commented 6 years ago

yep I have added it to the requirements in setup.py, @lopuhin . Thank you for pointing that out 😄