scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

Fix urljoin #51

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

Fix the urljoin so that the base url is not canonicalized by default.

codecov[bot] commented 6 years ago

Codecov Report

Merging #51 into master will decrease coverage by 0.66%. The diff coverage is 92%.

@@            Coverage Diff            @@
##           master     #51      +/-   ##
=========================================
- Coverage   61.37%   60.7%   -0.67%     
=========================================
  Files           2       3       +1     
  Lines         321     341      +20     
=========================================
+ Hits          197     207      +10     
- Misses        124     134      +10
Impacted Files Coverage Δ
scurl/canonicalize.pyx 19.46% <ø> (ø) :arrow_up:
scurl/scurl_helper.pxd 35.71% <83.33%> (ø)
scurl/cgurl.pyx 84.11% <94.73%> (-0.03%) :arrow_down: