scrapy / scurl

Performance-focused replacement for Python urllib
Apache License 2.0
21 stars 6 forks source link

Support urljoin for Scrapy PR #52

Closed malloxpb closed 6 years ago

malloxpb commented 6 years ago

This PR aims for fixing the build scrapy/scrapy#3332

codecov[bot] commented 6 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.23%. The diff coverage is 73.33%.

@@            Coverage Diff            @@
##           master     #52      +/-   ##
=========================================
+ Coverage   61.37%   61.6%   +0.23%     
=========================================
  Files           2       3       +1     
  Lines         321     349      +28     
=========================================
+ Hits          197     215      +18     
- Misses        124     134      +10
Impacted Files Coverage Δ
scurl/canonicalize.pyx 19.46% <ø> (ø) :arrow_up:
scurl/cgurl.pyx 86.15% <100%> (+2.01%) :arrow_up:
scurl/scurl_helper.pxd 60.97% <60.97%> (ø)
malloxpb commented 6 years ago

This PR is related to scrapy/url-chromium#1