scrapy / w3lib

Python library of web-related functions
BSD 3-Clause "New" or "Revised" License
392 stars 104 forks source link

Use latest version of Ubuntu #197

Closed Laerte closed 2 years ago

Laerte commented 2 years ago

All workflows of Scrapy org runs on ubuntu-latest runner, except for w3lib and tests workflow of scrapyd that's is being handled here

codecov[bot] commented 2 years ago

Codecov Report

Merging #197 (f223d6c) into master (74c9041) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files           6        6           
  Lines         471      471           
  Branches       90       90           
=======================================
  Hits          452      452           
  Misses          9        9           
  Partials       10       10           
Gallaecio commented 2 years ago

I’m slightly against this change.

Laerte commented 2 years ago

@Gallaecio While i understand your point, i think the use case that you mentioned in the comment is more valid if the project rely on external packages/libraries.

In our case we don't rely in any external package/library. So if the python interpreter is successfully installed we should not have any failing behaviour changing our runner.