search

scratchfoundation / scratch-blocks

Scratch Blocks is a library for building creative computing interfaces.
https://scratch.mit.edu/developers
Apache License 2.0
2.58k stars 1.38k forks source link

Say bubble disappears between two `Say [hello] for [x] seconds` blocks #1681

Open AbrahamJiang opened 6 years ago

AbrahamJiang commented 6 years ago

Expected Behavior

I did a function like this: 3 0 bugs

These words should show one by one.

Actual Behavior

But when those words showed, the screen flickered.

ps: I'm sorry, this .gif cannot catch "flicker", maybe you can try it yourself.

I tried it at scratch2.0, the screen did not flicker. 2 0

And I tried another function at scratch3.0, the screen did not flicker. 3 0 contrast

Operating System and Browser

Mac OS 10.13.3 Chrome 68.0.3440.106

mrjacobbloom commented 6 years ago

Could be related to LLK/scratch-vm#1035

thisandagain commented 6 years ago

@BryceLTaylor Can you repro?

BryceLTaylor commented 6 years ago

@thisandagain Sure can. I believe that the flicker in this case is the whole speech bubble disappearing at the end of each say block with a time. I've captured a higher frame rate gif: sayflicker

Here's the project: https://scratch.mit.edu/projects/239831253/

In 2.0 the say bubble stays present until a new say block appears. In @AbrahamJiang 's second example the say block without the time does not cause the sprite to stop saying anything and so you don't see the say bubble turn off.

I believe it should match 2.0.

BryceLTaylor commented 6 years ago

We should probably move this issue into either VM or Render (or GUI even).