towerofnix
commented
5 years ago A couple specific repro cases and error messages (testing on https://llk.github.io/scratch-gui/develop/):
(Expand, contains lengthy stack traces)
- Make a custom block.
- Make another custom block.
- Click "Make a Block" a third time. Browser freezes here.
- In the error log:
TypeError: e.workspace is undefined BlockBase Change setInputsInline setInputsInline SHAPE_STATEMENT apply jsonInit init Block BlockSvg newBlock
- "Make a Block", then press Cancel. Repeat several times over.
- Eventually the block palette regenerates with all blocks at the origin (0, 0) (the page does not freeze up) and this error:
TypeError: this.inputList is undefined appendInput_ appendInput_ appendDummyInput interpolate_ jsonInit init Block BlockSvg newBlock newBlock domToBlockHeadless_ domToBlockHeadless_ domToBlock show showAll_ refreshSelection refreshToolboxSelection_ - Switching to the Costumes tab and then back yields this weird layout issue:
and this error: NotFoundError: Node was not found createRect_ layout_ show showAll_ populate_ updateToolbox value toolboxUpdateTimeout4. Same weird layout and error when I switch to the costumes tab and back again, but switching to the stage the palette is fine and then switching back it's fine.
rachel-fenichel
Sorry for this mess of an issue/vague repro notes!
It's difficult to figure out exactly what the cause of any of these issues is, but they all have essentially the same effect: the Scratch page freezes up, becoming entirely unusable until I kill the tab ("a webpage is slowing down your browser, would you like to close it?" browser popup).
It's also not consistently reproducible. Messing around with the Scratch editor always causes it to freeze up eventually, but I can't always follow the same steps and have it crash at the same time.
Things that I've done right before the editor crashes:
Save for the first case (viewing the project page), it seems like it always happens when a workspace is reloaded. And/or maybe unloaded, which would account for exiting the editor?
I've also noticed that instead of freezing up, the block flyout will generate incorrectly with all the block SVGs positioned at the top-left of the flyout area, or the options in the context menus for variables in the flyout will stop working (something about
e.blockListbeing undefined? -- mind I may be misremembering that, I've reloaded the tab and cleared the console since).I'm using Firefox Developer Edition (69.0b7 / Linux) so it's not unreasonable to think there may be a bug in Firefox and not Scratch, but it's probably still worth investigating. I can't repro on Chromium. Edit: I can only repro this on dev edition, not Firefox ESR (60.7 / Linux, Mac).
This has been an issue for at least a couple weeks (on scratch.mit.edu) now. I can reproduce the same issues on llk.github.io, though (but again, not consistently).