scratchfoundation / scratch-desktop

Scratch 3.0 as a self-contained desktop application
BSD 3-Clause "New" or "Revised" License
348 stars 231 forks source link

Can’t hear “Text to Speech” ver 3.15.0 #157

Open TakahiroHIWAKI opened 4 years ago

TakahiroHIWAKI commented 4 years ago

Expected Behavior

speak text

Actual Behavior

donot speak to(cannot hear voice)

Steps to Reproduce

1) install Scratch desktop ver3.15.0 2) select extension “Text to Speech” 3) click on “speak(hello)” block but can’t hear “hello”

Operating System and Browser

I tried on windows 10 + scratch desktop 3.15.0

apple502j commented 4 years ago

Make sure you have Internet connection and nothing is blocking Scratch domain - for example, proxy, firewall, antivirus or country-wide censorship.

TakahiroHIWAKI commented 3 years ago

We can do ver3.14.0 but, latest ver3.15.0 CANNOT speech!

apple502j commented 3 years ago

Ah, can repro. 再現できました。

apple502j commented 3 years ago

For some reason body.buffer is undefined at scratch-vm/src/extensions/scratch3_text2speech/index.js speakAndWait. なぜかしらcratch-vm/src/extensions/scratch3_text2speech/index.js speakAndWait内のbody.bufferがundefinedになってます。

apple502j commented 3 years ago

@ericrosenbaum Where is body.buffer set? It seems like body is just a string with the data, not sure how it worked before. If requestType in the option is set as arraybuffer body should be ArrayBuffer.

ericrosenbaum commented 3 years ago

cc @BryceLTaylor @cwillisf

apple502j commented 3 years ago

@cwillisf Confirmed my theory was true:

kchadha commented 3 years ago

Looks like this will be fixed when LLK/scratch-vm#2891 goes in.

apple502j commented 3 years ago

@kchadha This can be closed