"w"ait extension commands make no connection attempt

scratchfoundation / scratch-flash

Open source version of the Scratch 2.0 project editor. This is the basis for the online and offline versions of Scratch found on the website.

https://scratch.mit.edu

GNU General Public License v2.0

1.33k stars 512 forks source link

"w"ait extension commands make no connection attempt #320

Closed techninja closed 10 years ago

techninja commented 10 years ago

On release v404, I'm testing an experimental extension to control my daughter's watercolor painting robot. Since this is a real robot, it needs time to make its movements, and though I've written the connecting API correctly to spec (to add/remove the _busy IDs from /poll), it seems the initial command for any "w" defined waiting blocks _never_ actually sends!

I've confirmed this via wireshark, and though the other straight "open loop" style commands work fine, the send and wait for complete simply does not.

nathan commented 10 years ago

They work on the most recent master. There hasn't been an offline release in a while; @sclements should be able to do one soon.

cpseager commented 10 years ago

You can test for now by by using the offline version to import the .s2e file and then save the project as a sb2 file via File>Save. Then open the sb2 file in the online version instead (File>Upload from my computer) - wait blocks will then work and can be tested.

techninja commented 10 years ago

Thanks for the quick response! I'll see if I can't test the online version with an sb2.

Out of curiosity, why are two important parts of the HTTP standard (request time and response body) totally ignored? It should be possible to quite simply implement their use for both wait duration and data retrieval as is usually the standard. Not that the system doesn't work, just that it seems a little... odd.

nathan commented 10 years ago

I'm not sure. We do currently use request time and response body for blocking reporters (despite what the documentation says), but not for blocking commands. I filed a new issue for that (#328), so this can be closed now.