search

scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.34k stars 3.42k forks source link

Remove global box-sixing css #2022

Open chrisgarrity opened 6 years ago

chrisgarrity commented 6 years ago

The playground css sets: * { box-sizing: border-box; }

Components in the GUI depend on this box sizing.

When the GUI is not running in the playground there are unexpected side effects - especially as components do not inherit box-sizing from the enclosing element.

This has led to various other .class * { box-sizing: border-box; } scattered throughout the gui to deal with problems when embedded on www.

We should remove the playground setting (also other examples) and set it directly on the elements that need it. Otherwise there will be intermittent bugs that only show up after the gui is embedded in www (or elsewhere)

LiFaytheGoblin commented 5 years ago

Apart from #3009 and #2932 are there other issues that might be caused by the box sizing? It is a comming practise to specify the box sizing for * so I wonder if removing it is the best option.