scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.33k stars 3.42k forks source link

[Vector Editor] Stroke / outline inconsistencies #3361

Open Ascor8522 opened 5 years ago

Ascor8522 commented 5 years ago

Hello,

I have noticed 2 major inconsistencies / bug related to strokes / outlines of vector objects in the paint editor.

1.

Description

When multiple shapes are grouped, and this group is selected, the group's stroke thicness reported by the number input is wrong / falls back to 0.

Steps

  1. Go in the costume editor
  2. Create a shape
  3. Create a 2nd shape
  4. Group those 2 shapes together
  5. Select that new group
  6. Apply some outline to that group
  7. De-select the group
  8. Re-select the group

ezgif com-crop

Expected behavior

The right outline thicness is reported.

Actual behavior

The reported outline thicness is 0.

2.

Description

When multiple shapes are grouped, and one of those shapes has never had an outline, and when trying to apply an outline to the whole group, only the shapes that had previously had an oultine actually have the new outline applied.

Steps

  1. Go in the costume editor
  2. Create a shape
  3. Give that shape a stroke
  4. Create a 2nd shape
  5. Make sure that 2nd shape doesn't have a stroke or didn't have a stroke when created.
  6. Group thos 2 shapes together.
  7. Select that new group
  8. Apply some outline to that group

Expected behavior

The outline is applied to all shapes of that group.

Actual behavior

Only the shapes that have previously had an outline are applied the new outline.


Issue 1 first discovered in 2018 Microsoft Windows [version 10.0.17134.345] Google Chrome 69.0.3497.100 (64 bits) Javascript V8 6.9.427.23

Issue 2 discovered in 2022 (Scratch 3.26) Microsoft Windows [version 10.0.19044.1415] Google Chrome 96.0.4664.110 (64 bits) JavaScript V8 9.6.180.21

thisandagain commented 5 years ago

/cc @fsih @carljbowman