scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.42k stars 3.51k forks source link

Whale project in Japanese positions gui so the green flag is hidden #3572

Open BryceLTaylor opened 5 years ago

BryceLTaylor commented 5 years ago

Expected Behavior

The gui should appear the same no matter which language it is set in and which project is loaded.

Actual Behavior

If you load the whale project, https://llk.github.io/scratch-gui/develop/#16795490, and change the language to Japanese (either variant) all of the elements of the gui below the menu bar slide upwards. This leaves a gap at the bottom and the green flag, the stop button, and all but a tiny sliver of the code/costume/sound tabs are obscured by the menu bar.

image19

Steps to Reproduce

Load the project from above Change the language to Japanese (日本語 or にほんご) Note: the elements of the gui slide up and you can't click the green flag.

This does not seem to happen with the default project and I'm not sure what it is about that project that causes this issue. In other languages, such as english, it slides up a tiny amount. You can see a small gap below the backpack area.

Operating System and Browser

Mac Chrome

thisandagain commented 5 years ago

/cc @chrisgarrity

yokobond commented 5 years ago

I made a simple test project of this problem.

Low Location of Block-Comment hides Start-flag https://scratch.mit.edu/projects/277804252/

When the location of a block-comment too low from the highest script, the start/stop and tabs were hidden by menus. This problem is found only in the language 「日本語」「にほんご」「한국어」.

chrisgarrity commented 5 years ago

Ah, thank you @yokobond for finding the minimal case of this. It's not just Japanese. It happens in every language, but just isn't as noticeable. Here's the minimal project in English: screen shot 2019-01-08 at 9 54 32 am

Note that the backpack is not flush with the bottom of the window, and the buttons are touching the navbar. Other languages such as German and Hungarian also lose the buttons completely.

So the correct expected behavior should be that the gui appears the same no matter where block comments are placed on the workspace.

BryceLTaylor commented 5 years ago

I've gotten another report of this issue from Fresh Desk. They were using Catalan on these projects: https://scratch.mit.edu/projects/10128407/editor/, https://scratch.mit.edu/projects/284516654/editor/, and https://scratch.mit.edu/projects/284516654/editor/.

They say: Try to choose Catalan, Deutsch or the first one on the dropdown menu and you will see. This happens with both signed in and no signed in, on Windows 10 and Windows 7. Last Chrome version: 72.0.3626.119 (Build oficial) (64 bits). I attached two screenshots.

screenshot-no-signed-in screenshot-signed-in

chrisgarrity commented 5 years ago

while this is most noticeable in some languages it is not a localization problem. It has to do with the positioning of the block comment, and probably should get moved to scratch-blocks.

BryceLTaylor commented 5 years ago

This came up again from the community with this project (switch to Japanese or Korean): https://scratch.mit.edu/projects/315657668/