search

scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.42k stars 3.51k forks source link

When a remix fails it hangs and there's no see community button #4037

Open BryceLTaylor opened 5 years ago

BryceLTaylor commented 5 years ago

Expected Behavior

Remixes in the editor should succeed and if they don't they should stop trying after a while and leave the "see community" button.

Actual Behavior

When a remix fails it keeps showing you the alert that says it's trying to remix. During this time the "See community" button is not present.

Steps to Reproduce

Sign in on Scratch.ly Navigate to the main page Click "Chess Escape" Click "See Inside" Note: you should see the project in the editor Click "Remix" in the top bar Note: the green alert that says "remixing" stays there forever and there is no "see community" button. It should probably time out and give some sort of error alert.

The inability to remix that project is already recorded in this issue: https://github.com/LLK/scratch-projects/issues/96

Operating System and Browser

e.g. Mac OS 10.11.6 Safari 10.0

benjiwheeler commented 5 years ago

The problem with Chess Escape was fixed (See https://github.com/LLK/scratch-projects/issues/96#issuecomment-450387734 , https://github.com/LLK/scratch-parser/pull/50).

I can't seem to replicate the "hanging remix alert" issue, at least not using the connection settings in Chrome dev tools. It seems to give up after a while, and prompt you to try again or cancel.

This may be closable, though it's hard to know for sure that the problem is solved in all cases.