scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.48k stars 3.59k forks source link

Should we warn users for leaving a project page with a running project #4110

Open BryceLTaylor opened 5 years ago

BryceLTaylor commented 5 years ago

@kathymakes writes: When I am using a project with cloud variables from the project page - and then I try to leave the page - it throws a browser modal: “The page is asking to confirm you that you want to leave, data you entered may not be saved.” Is this intentional?

Steps to Reproduce

Navigate to the project page of a project that uses cloud variables such as https://scratch.ly/projects/1300001322/ Run the project Click a link in the header such as About Note: a browser dialog appears saying "Leave Site Changes you made may not be saved"

It does not matter if you own the project or not. You do need to run the project to see the dialog.

Operating System and Browser

Mac Chrome

BryceLTaylor commented 5 years ago

It seems to happen on any project page, with or without a cloud variable. As long as you run the project, you get the notice when navigating away from the project page.

@fsih wrote: On my censored project page ,I edited my description and then clicked the scratch logo, and it asked me if I was sure I wanted to leave because there were unsaved changes, which was weird. I think that’s only supposed to come up from the editor page?

I believe this is the same issue. I also tested on another project that was just a regular project without cloud variables that wasn't censored.