scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.47k stars 3.57k forks source link

Accidental rename of sprite #4334

Open griffpatch opened 5 years ago

griffpatch commented 5 years ago

Expected Behavior

Sprites don't get renamed by accident, but if they do, then the project keeps running as expected.

Actual Behavior

The first problem is that in Scratch 3, it is really easy to accidentally rename a sprite. The sprite name box is always editable, and is only one tab away from the Green Flag button. So when you play a game you can be accidentally entering characters into the current sprite name without realising it. I did it myself while recording a screencast, and then someone following my screencast tutorial had exactly the same problem! This could not happen in Scratch 2. I think you may want a rethink about how easy it is to change (perhaps add an edit icon next to the sprite name?)

The second problem, is if a project is running, and you change the name of the sprite. All "touching " referencing that sprite stop working. They remain broken until you click into the scripts pane of the sprite doing the detection, and then they fix. (This is not always the case, but most of the time - sometimes they remain broken until you name it back or apparently, use the STOP THIS SCRIPT block - can't verify that one as it came from another scratcher).

Third problem - having written the above, I realised that I must have got the very point it all went wrong recorded in my uncut screencast video. So I have reviewed it, and it's VERY confusing. It looks like the word "2rms" was appended to the end of my sprite name while I was 'undoing' changes to a sprite's costume with the project running?

20190112161804_trim

So at the point where the name of the sprite suddenly changes from Platforms to Platforms2rms, this is where I click Ctrl-Z to undo my last change, and then repeatedly after that again press Ctrl-Z... For some reason the Name of the sprite is suddenly highlighted and 2rms gets appended! Uncertain of the how or why... The keys appear to far away to have been accidentally pressed, and the sound in the recording (you can't hear) only recorded the click of the undo button, no other typing to suggest I was typing elsewhere. As I have said, I have had another scratcher report the very same sprite created in their own project having the same issue just the next day after I had it... So this might be an issue with the UNDO feature in paint editor perhaps? Just guessing here!

Steps to Reproduce

Do as above (good luck!)

Operating System and Browser

e.g. Mac OS 10.11.6 Safari 10.0

towerofnix commented 5 years ago

All "touching " referencing that sprite stop working. They remain broken until you click into the scripts pane of the sprite doing the detection, and then they fix.

I noticed the same problem with renaming costumes - the updated costume names will not appear and be active in your scripts until you switch back to the scripts pane.

d-siganos commented 5 years ago

@griffpatch this is CONSTANTLY happenning to me

Ocean-OS commented 3 years ago

Yeah this always happens to me

DNin01 commented 2 years ago

This happens when you press Ctrl+Z. I think the editor and the browser undo something simultaneously. We need to tell the browser not to undo when you press Ctrl+Z because this shortcut is already used by the Scratch editor.