scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.44k stars 3.53k forks source link

"Delete" for backpack items is blue, others are orange #4406

Open paulkaplan opened 5 years ago

paulkaplan commented 5 years ago

@carljbowman @benjiwheeler not sure if you wanted the backpack tile to also have a red-backgrounded delete item in the context menu

The context menu on the sprite list image

The context menu on backpack items image

benjiwheeler commented 5 years ago

I didn't realize it would affect menus beyond the sprite context menu. Yeah, it strikes me that if we're doing it in some places, we should also do it in others. Though, since it's the only item in the backpack menu, it might not need the same special treatment...

towerofnix commented 5 years ago

The "delete" option in costume and sound tiles is also blue (and there's another option "duplicate" in those cases).

benjiwheeler commented 5 years ago

I'm confused -- checking on the staging site now, it does look like the backpack (and costumes/sounds tiles) context menu has a red-orange rollover:

image

image

@paulkaplan Can you check it now? I don't understand why we saw blue before... there haven't been any other code changes, have there?

towerofnix commented 5 years ago

Oh oops, it does seem to be fixed now. I've just been working on a project so long I hadn't reloaded the page with recent changes! All "delete" menu icons are now orange for me. (On my old page, which I haven't reloaded, they're all the original blue - even the sprite-delete option.) So I can't repro this myself. (Although my old page may not have had the issue in the first place, since it never even knew about the code for making delete context menu options orange.)

thisandagain commented 5 years ago

I'm going to flag this as help wanted. The desired fix is to update the backpack to match the rest of the UI.

/cc @carljbowman