scratchfoundation / scratch-gui

Graphical User Interface for creating and running Scratch 3.0 projects.
https://scratchfoundation.github.io/scratch-gui/develop/
BSD 3-Clause "New" or "Revised" License
4.42k stars 3.51k forks source link

Page doesn't load on iphone for certain game #4707

Open BryceLTaylor opened 5 years ago

BryceLTaylor commented 5 years ago

Expected Behavior

The game loads and runs.

Actual Behavior

This project, https://scratch.mit.edu/projects/280814631/ , loads on mac chrome, but on chrome on ios it gets to the project page and the project shows it's loading. After a few seconds, the whole page becomes an "Aw, Snap!" page.
48355

On Safari it immediately reloads, and the second time redirects you to an error page: 63644

On Mac Chrome, the project loads just fine, but there are warnings in the console:

Screen Shot 2019-04-01 at 10 03 46 AM

This came to us from the community:

Screen Shot 2019-04-01 at 10 07 24 AM

Steps to Reproduce

On an iphone go to https://scratch.mit.edu/projects/280814631/ Note: it goes to the project page and tries to load the project. Eventually the whole page becomes an error page Try on Chrome or Safari On Chrome on Mac launch the project Note: it loads Check the console Note: there are warnings

Operating System and Browser

ios Chrome, ios Safari

BryceLTaylor commented 5 years ago

Here is another project that I've seen this issue in: https://scratch.mit.edu/projects/288899996/

gnarf commented 5 years ago

^ worth noting that second project loads - its after you play it for a few seconds (depending on the phone) it will crash -- seen it crash a different points

mzgoddard commented 5 years ago

I'm not sure if it is the cause but the two projects listed here so far are each trying to send a 0x0 image to webgl. And its sending errors back to us.

The errors may be cascading into crashing the browser tab.

Here are (at least one of) the 0x0 svgs from each project. I captured them from the img.onload in svg-renderer.jsx.

280814631

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="0" height="0" viewBox="0 0 0 0">
  <!-- Exported by Scratch - http://scratch.mit.edu/ -->
</svg>
data:image/svg+xml;utf8,<svg%20xmlns%3D"http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg"%20xmlns%3Axlink%3D"http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink"%20version%3D"1.1"%20width%3D"0"%20height%3D"0"%20viewBox%3D"0%200%200%200">%0A%20%20<!--%20Exported%20by%20Scratch%20-%20http%3A%2F%2Fscratch.mit.edu%2F%20-->%0A<%2Fsvg>

288899996

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="0" height="0" viewBox="0 0 0 0">
  <!-- Exported by Scratch - http://scratch.mit.edu/ -->
</svg>
data:image/svg+xml;utf8,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20xmlns%3Axlink%3D%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%22%20version%3D%221.1%22%20width%3D%220%22%20height%3D%220%22%20viewBox%3D%220%200%200%200%22%3E%0A%20%20%3C!--%20Exported%20by%20Scratch%20-%20http%3A%2F%2Fscratch.mit.edu%2F%20--%3E%0A%3C%2Fsvg%3E
BryceLTaylor commented 5 years ago

Here is another project I've seen this issue on: https://scratch.mit.edu/projects/273315704/ It comes with these errors when opening on Mac Chrome: Screen Shot 2019-04-22 at 10 15 30 AM

BryceLTaylor commented 5 years ago

And here's another one: https://scratch.mit.edu/projects/281006639/ It plays for a second or so and then gives the error. Screen Shot 2019-04-22 at 10 25 31 AM