search

scratchfoundation / scratch-link

Device interoperability layer for Windows and MacOS
BSD 3-Clause "New" or "Revised" License
102 stars 83 forks source link

BLE 'getServices' not implemented #104

Closed evhan55 closed 5 years ago

evhan55 commented 5 years ago

Expected Behavior

Sending a getServices request over BLE to Scratch Link will send a list of available services advertised by the peripheral, as documented here: https://github.com/LLK/scratch-link/blob/develop/Documentation/BluetoothLE.md#enumerating-services

Actual Behavior

A getServices request returns a Method not found error

Operating System and Browser

Mac, as discovered by @spectranaut

evhan55 commented 5 years ago

Seem to be missing implementation:

https://github.com/LLK/scratch-link/blob/develop/Windows/scratch-link/BLESession.cs#L135

https://github.com/LLK/scratch-link/blob/develop/macOS/Sources/scratch-link/BLESession.swift#L529

evhan55 commented 5 years ago

A reference: https://googlechrome.github.io/samples/web-bluetooth/discover-services-and-characteristics.html

evhan55 commented 5 years ago

Resolved via https://github.com/LLK/scratch-link/pull/123