Behavior of unrecognized filter options varies by platform

scratchfoundation / scratch-link

Device interoperability layer for Windows and MacOS

BSD 3-Clause "New" or "Revised" License

102 stars 83 forks source link

Behavior of unrecognized filter options varies by platform #141

Open cwillisf opened 5 years ago

cwillisf commented 5 years ago

Expected Behavior

The Windows and macOS versions of Scratch Link should behave the same.

Actual Behavior

If the client supplies unrecognized filter options:

on macOS, the unrecognized options are ignored
on Windows, the unrecognized options are treated as an error

Either behavior could be considered correct but both platforms should behave the same. The current macOS behavior makes it easier to add features over time without breaking older versions of Scratch Link.

cwillisf commented 5 years ago

This affects LLK/scratch-vm#2231 in an unfortunate way. It's too late to do anything about that one but it does prove that this isn't just a theoretical problem.