search

scratchfoundation / scratch-link

Device interoperability layer for Windows and MacOS
BSD 3-Clause "New" or "Revised" License
102 stars 83 forks source link

BLE: allow client to override write with/without response #159

Closed cwillisf closed 4 years ago

cwillisf commented 4 years ago

Resolves

Resolves #150 Closes #154

Proposed Changes

In #154, @terado0618 implemented a fix for #150 on Windows. This PR includes #154 along with a similar change for macOS and documentation of the new behavior.

Reason for Changes

This offers a significant performance boost on Windows: see this comment. Performance on macOS seems to be acceptable without this change, but I think it's important for the hardware communication to be similar on both platforms so that extensions don't need to worry about platform differences.

This PR should be merged with LLK/scratch-vm#2298.

@terado0618, please let me know if you have concerns about this PR. Thanks!

terado0618 commented 4 years ago

LGTM. Thanks!

cwillisf commented 4 years ago

I'm going to merge this as-is for now but I've filed #161 to follow up on the review comments later.