scratchfoundation / scratch-vm

Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0
http://scratchfoundation.github.io/scratch-vm/
BSD 3-Clause "New" or "Revised" License
1.19k stars 1.47k forks source link

All instruments decay away eventually #1411

Open TheLogFather opened 5 years ago

TheLogFather commented 5 years ago

Expected Behavior

In Scratch 2, some of the instruments (e.g. organ, clarinet, synth pad/lead) will hold a note indefinitely (or at least a very very long time...) if you specify a large number of beats.

Actual Behavior

In Scratch 3, the note decays after a few seconds.

Steps to Reproduce

Click on a block "set instrument to [(3) Organ]" to use the organ. Click on a block "play note (60) for (10) beats" to start playing a note for ~10 secs.

Note that in Scratch 2 the note continues until the ten beats are done (i.e. while the block remains highlighted). In Scratch 3, the note stops before the ten beats, yet the block remains highlighted for the full ten beats.

Operating System and Browser

N/A


(See also discussion in https://github.com/LLK/scratch-vm/issues/949#issuecomment-409352697)

thisandagain commented 5 years ago

/cc @ericrosenbaum