search

scratchfoundation / scratch-vm

Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0
http://scratchfoundation.github.io/scratch-vm/
BSD 3-Clause "New" or "Revised" License
1.21k stars 1.51k forks source link

Comments attached to custom block definitions in 2.0 do not attach to correct blocks in 3.0 #1499

Open amylh opened 6 years ago

amylh commented 6 years ago

Expected Behavior

In Scratch 3.0, comments should attach to the same blocks as in the 2.0 version of the project.

Actual Behavior

Comments attached to custom block definitions in 3.0 are attached to the wrong blocks, usually the blocks below the correct ones.

Steps to Reproduce

Open any project containing comments attached to custom block definitions. Compare the comments in 2.0 and 3.0. I have included an example project below, with pictures: 2.0 version: https://scratch.mit.edu/projects/165201011/#editor 3.0 preview: https://beta.scratch.mit.edu/#165201011

diagram

Operating System and Browser

Linux Mint 18.1 Mozilla Firefox, Google Chrome

Windows 10 Microsoft Edge, Google Chrome

towerofnix commented 6 years ago

I would venture to guess this might have to do with importing comments which are attached to custom block definitions.

thisandagain commented 6 years ago

/cc @kchadha