scratchfoundation / scratch-vm

Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0
http://scratchfoundation.github.io/scratch-vm/
BSD 3-Clause "New" or "Revised" License
1.2k stars 1.49k forks source link

Translate extension language reporter gives incorrect results #1561

Open ericrosenbaum opened 6 years ago

ericrosenbaum commented 6 years ago

Expected Behavior

The language extension's language reporter should report the name of the language the editor is currently set to, in that language. E.g. if you set the editor to spanish, the block reports "español".

Actual Behavior

The result is incorrect for some languages. There are three types of issue:

apple502j commented 6 years ago

I am sure it's duplicate, but I can guess third one happens when it's defined in Scratch (zh-TW, ja-HR, pt-BR, else...)

picklesrus commented 5 years ago

Also see https://github.com/LLK/scratch-gui/issues/2862. I think that might be an instance of this problem as well

picklesrus commented 5 years ago

Here's an additional list of problems

We should also update the language map code to use l10n (I'm pretty sure it wasn't done when the map code was written)

L10n also has a list of exceptions that we should manually test and make sure we integrate into the language map code.