search

scratchfoundation / scratch-vm

Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0
http://scratchfoundation.github.io/scratch-vm/
BSD 3-Clause "New" or "Revised" License
1.2k stars 1.49k forks source link

Hardware Extensions: sometimes device doesn't disconnect when Scratch disconnects from it #1845

Open evhan55 opened 5 years ago

evhan55 commented 5 years ago

Expected Behavior

When I click 'Disconnect' in the connect dialog while a WeDo2 is connected, the status icon should turn orange and the WeDo2 LED should turn off and go into 'disconnected' mode, and no data should be sent or received

Actual Behavior

Sometimes, when I click 'Disconnect' in the connect dialog while a WeDo2 is connected, the status icon does turn orange, but the WeDo2 LED remains on and it does not go into 'disconnected' mode, although no data seems to be sent or received

Steps to Reproduce

  1. Connect to WeDo2
  2. Click 'Disconnect' in the modal dialog
  3. WeDo2 LED should turn off, but sometimes it does not
  4. EDIT : Also seen for micro:bit and BOOST

Operating System and Browser

Mac Mojave, Chrome

evhan55 commented 5 years ago

I am not able to reproduce this today, and I am wondering if it may have been inadvertently fixed by https://github.com/LLK/scratch-vm/pull/1763, but I am not sure

evhan55 commented 5 years ago

Nevermind, reproduced it today, but don't have clear STR

evhan55 commented 5 years ago

@ericrosenbaum May have experienced this with the micro:bit on macOS today

evhan55 commented 5 years ago

@ericrosenbaum and others may have experienced this with the BOOST on Windows on Scratch Day