search

scratchfoundation / scratch-vm

Virtual Machine used to represent, run, and maintain the state of programs for Scratch 3.0
http://scratchfoundation.github.io/scratch-vm/
BSD 3-Clause "New" or "Revised" License
1.2k stars 1.5k forks source link

Seagulls MAP shows regression, the sprite with the word Breathe doesn't hide #2257

Open BryceLTaylor opened 5 years ago

BryceLTaylor commented 5 years ago

Expected Behavior

This was already reported in issue https://github.com/LLK/scratch-vm/issues/1478 and was fixed. I'm not sure when but we seem to have had a regression on the part of the issue related to the Seagulls Map.

At some point in this project https://scratch.mit.edu/projects/169401431/ the sprite "PART 13 rocks" switches to a costume that says Breathe and is supposed to hide a moment later.

Actual Behavior

The word "Breathe" does not disappear. breatheBug (From old bug)

Screen Shot 2019-08-12 at 2 25 54 PM From 08/12/19.

Steps to Reproduce

Click the green flag on the project Note, after the word "Breathe" appears (a few minutes in) it doesn't disappear

Operating System and Browser

Mac Chrome

BryceLTaylor commented 5 years ago

@ktbee Sorry to get this song stuck in your head again, but it's back.

BryceLTaylor commented 5 years ago

From the old issue: from @mzgoddard In 169401431: Breathe does not disappear because there is a race condition in the wait blocks. There are 2 separate when I receive hats, the first that fires waits 0.4 seconds and then shows the Breathe text. The second when I receive hat hides the Breathe text. The 0.4 second timer should complete and show Breathe before the second hat executes. Instead the 0.4 second timer is firing after the second hat, causing a hide then a show to execute.