scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.59k stars 840 forks source link

iPad view of TTT page - modal extends off edge of screen (landscape) #1042

Open jwzimmer-zz opened 7 years ago

jwzimmer-zz commented 7 years ago

Using an iPad ("Toast") + Safari, Staging

There are 3 fairly minor issues, 1 in portrait and 2 in landscape mode (are we supporting landscape mode?): 1) In portrait mode, the footer columns/ links are squished together. There isn't enough padding in between them. --> https://github.com/LLK/scratch-www/issues/1052 2) In landscape mode, the modal extends off the bottom of the page. 3) In landscape mode, clicking outside the modal doesn't close it.

img_2262

A little more description of using an iPad to view the TTT page (see https://github.com/LLK/scratch-www/pull/1006#issuecomment-261662764), if needed:

mewtaylor commented 7 years ago

The footer issue is outside the scope of the TTT page and a separate issue, and likely in production already. I'll look into the modal being too long.

chrisgarrity commented 7 years ago

Just to confirm, I was able to get the squished footer on the splash page on production with my Nexus 5X phone, so the footer is definitely out of scope for TTT.

chrisgarrity commented 7 years ago

Some additional testing on Samsung 7-inch Android tablet: In portrait mode:

Landscape mode:

jwzimmer-zz commented 7 years ago

Moved the issue @chrisgarrity found with the Android showing 2 col but wrong order to https://github.com/LLK/scratch-www/issues/1054.